Merge pull request JakeChampion#36 from github/reject-with-error

Reject promise with TypeError for network failures.
bwasti · Nov 21, 2014 · e184d6e · e184d6e
2 parents 502798d + 67152c2
commit e184d6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/fetch.js b/fetch.js
@@ -162,7 +162,7 @@
       xhr.onload = function() {
         var status = (xhr.status === 1223) ? 204 : xhr.status
         if (status < 100 || status > 599) {
-          reject()
+          reject(new TypeError('Network request failed'))
           return
         }
         var options = {
@@ -174,7 +174,7 @@
       }
 
       xhr.onerror = function() {
-        reject()
+        reject(new TypeError('Network request failed'))
       }
 
       xhr.open(self.method, self.url)

diff --git a/test/test.js b/test/test.js
@@ -54,8 +54,8 @@ asyncTest('rejects promise for network error', 1, function() {
   fetch('/error').then(function(response) {
     ok(false, 'HTTP status ' + response.status + ' was treated as success')
     start()
-  }).catch(function() {
-    ok(true)
+  }).catch(function(error) {
+    ok(error instanceof TypeError, 'Rejected with Error')
     start()
   })
 })