-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Python 3.8 support #123
Conversation
3bc5126
to
6d1756b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Probably about time.
I think there are also a few checks for sys.version_info >=(3, 9)
if you grep in tests that can be removed.
Pull Request Test Coverage Report for Build 12917084840Details
💛 - Coveralls |
Removes support for Python 3.8, which became EOL on 2024-10-07: https://peps.python.org/pep-0569/
6d1756b
to
f369112
Compare
Good call! I just removed those |
Last two bits. Thanks again. Interested in working on anything else? |
@bwhmather For sure! I'm looking to contribute to the open-source tools I use. Feel free to assign me an issue you've been meaning to get to, and I'll take a look at open issues, too |
CI is complaining. Try running As for other stuff to fix, the most pressing one is probably #62. Feel up for it? |
@bwhmather I just fixed that file, and I'm up to take a crack at #62 for sure |
Merged. Thank you very much. |
Removes support for Python 3.8, which became EOL on 2024-10-07:
https://peps.python.org/pep-0569/