Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Python 3.8 support #123

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

johnfraney
Copy link
Contributor

Removes support for Python 3.8, which became EOL on 2024-10-07:

https://peps.python.org/pep-0569/

Copy link
Owner

@bwhmather bwhmather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Probably about time.

I think there are also a few checks for sys.version_info >=(3, 9) if you grep in tests that can be removed.

@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12917084840

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 98.625%

Totals Coverage Status
Change from base Build 11673496203: 0.5%
Covered Lines: 1363
Relevant Lines: 1382

💛 - Coveralls

Removes support for Python 3.8, which became EOL on 2024-10-07:

https://peps.python.org/pep-0569/
@johnfraney
Copy link
Contributor Author

I think there are also a few checks for sys.version_info >=(3, 9) if you grep in tests that can be removed.

Good call! I just removed those

src/ssort/_utils.py Outdated Show resolved Hide resolved
tests/test_ast.py Outdated Show resolved Hide resolved
@bwhmather
Copy link
Owner

Last two bits. Thanks again. Interested in working on anything else?

@johnfraney
Copy link
Contributor Author

Last two bits. Thanks again. Interested in working on anything else?

@bwhmather For sure! I'm looking to contribute to the open-source tools I use. Feel free to assign me an issue you've been meaning to get to, and I'll take a look at open issues, too

@bwhmather
Copy link
Owner

CI is complaining. Try running black on test_bindings.py.

As for other stuff to fix, the most pressing one is probably #62. Feel up for it?

@johnfraney
Copy link
Contributor Author

CI is complaining. Try running black on test_bindings.py.

As for other stuff to fix, the most pressing one is probably #62. Feel up for it?

@bwhmather I just fixed that file, and I'm up to take a crack at #62 for sure

@bwhmather bwhmather merged commit fe8013a into bwhmather:master Jan 23, 2025
19 checks passed
@bwhmather
Copy link
Owner

Merged. Thank you very much.

@johnfraney johnfraney deleted the remove-python3.8 branch January 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants