forked from netty/netty
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use the index-based AsciiString constructor instead of substring()
Motivation: The construction `new AsciiString(string.substring(...))` can be replaced with the `new AsciiString(string, start, length)` to avoid extra allocation. Modifications: Apply the described replacement in `HttpConversionUtil#setHttp2Authority`. Result: Less allocations.
- Loading branch information
1 parent
0234878
commit ba27456
Showing
2 changed files
with
68 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright 2017 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package io.netty.handler.codec.http2; | ||
|
||
import io.netty.util.AsciiString; | ||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
public class HttpConversionUtilTest { | ||
@Test | ||
public void setHttp2AuthorityWithoutUserInfo() { | ||
Http2Headers headers = new DefaultHttp2Headers(); | ||
|
||
HttpConversionUtil.setHttp2Authority("foo", headers); | ||
assertEquals(new AsciiString("foo"), headers.authority()); | ||
} | ||
|
||
@Test | ||
public void setHttp2AuthorityWithUserInfo() { | ||
Http2Headers headers = new DefaultHttp2Headers(); | ||
|
||
HttpConversionUtil.setHttp2Authority("info@foo", headers); | ||
assertEquals(new AsciiString("foo"), headers.authority()); | ||
|
||
HttpConversionUtil.setHttp2Authority("@foo.bar", headers); | ||
assertEquals(new AsciiString("foo.bar"), headers.authority()); | ||
} | ||
|
||
@Test | ||
public void setHttp2AuthorityNullOrEmpty() { | ||
Http2Headers headers = new DefaultHttp2Headers(); | ||
|
||
HttpConversionUtil.setHttp2Authority(null, headers); | ||
assertNull(headers.authority()); | ||
|
||
HttpConversionUtil.setHttp2Authority("", headers); | ||
assertSame(AsciiString.EMPTY_STRING, headers.authority()); | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void setHttp2AuthorityWithEmptyAuthority() { | ||
HttpConversionUtil.setHttp2Authority("info@", new DefaultHttp2Headers()); | ||
} | ||
} |