Skip to content

Commit

Permalink
Attempt llvm-mirror#3 to placate MSVC.
Browse files Browse the repository at this point in the history
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@281197 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
zygoloid committed Sep 12, 2016
1 parent 1f95189 commit 4d206e7
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions utils/TableGen/ClangDiagnosticsEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -926,16 +926,18 @@ struct DiagText {
void print(std::vector<std::string> &RST) override;
};

std::vector<std::unique_ptr<Piece>> Pieces;
// FIXME: This should be a unique_ptr, but I can't figure out how to get MSVC
// to not issue errors on that.
std::vector<std::shared_ptr<Piece>> Pieces;

DiagText();
DiagText(DiagText &&O) : Pieces(std::move(O.Pieces)) {}
DiagText(DiagText &&O) LLVM_NOEXCEPT : Pieces(std::move(O.Pieces)) {}

DiagText(StringRef Text);
DiagText(StringRef Kind, StringRef Text);

template<typename P> void add(P Piece) {
Pieces.push_back(llvm::make_unique<P>(std::move(Piece)));
Pieces.push_back(std::make_shared<P>(std::move(Piece)));
}
void print(std::vector<std::string> &RST);
};
Expand Down Expand Up @@ -1032,7 +1034,7 @@ DiagText::DiagText(StringRef Kind, StringRef Text) : DiagText(parseDiagText(Text
Prefix.Role = Kind;
Prefix.Text = Kind;
Prefix.Text += ": ";
Pieces.insert(Pieces.begin(), llvm::make_unique<TextPiece>(std::move(Prefix)));
Pieces.insert(Pieces.begin(), std::make_shared<TextPiece>(std::move(Prefix)));
}

void escapeRST(StringRef Str, std::string &Out) {
Expand Down

0 comments on commit 4d206e7

Please sign in to comment.