Skip to content

Commit

Permalink
HHH-13043 Upgrade to JAXB 2.3.1
Browse files Browse the repository at this point in the history
... which has a correctly formatted POM, and doesn't wreak havoc in
projects depending on us and using Maven + JDK11.
  • Loading branch information
yrodiere authored and gsmet committed Nov 23, 2018
1 parent 809eec8 commit aa2648d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
16 changes: 10 additions & 6 deletions gradle/libraries.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ ext {

jodaTimeVersion = '2.3'

jaxbApiVersion = '2.3.1'
// We can't upgrade JAXB in Karaf (yet), but fortunately everything works fine with the version built in Karaf
jaxbApiVersionOsgiRange = "[2.2,3)"
jaxbRuntimeVersion = '2.3.1'

libraries = [
// Ant
ant: 'org.apache.ant:ant:1.8.2',
Expand Down Expand Up @@ -75,14 +80,13 @@ ext {
logging_processor: 'org.jboss.logging:jboss-logging-processor:2.1.0.Final',

// jaxb task
// Strangely, jaxb-runtime 2.2.11 depends on jaxb-api 2.2.12-b140109.1041
jaxb_api: 'javax.xml.bind:jaxb-api:2.2.12-b140109.1041',
jaxb_runtime: 'org.glassfish.jaxb:jaxb-runtime:2.2.11',
jaxb_xjc: 'org.glassfish.jaxb:jaxb-xjc:2.2.11',
jaxb_api: "javax.xml.bind:jaxb-api:${jaxbApiVersion}",
jaxb_runtime: "org.glassfish.jaxb:jaxb-runtime:${jaxbRuntimeVersion}",
jaxb_xjc: "org.glassfish.jaxb:jaxb-xjc:${jaxbRuntimeVersion}",
// Note that jaxb2_basics is a set of tools on *top* of JAXB.
// See https://github.com/highsource/jaxb2-basics
jaxb2_basics: 'org.jvnet.jaxb2_commons:jaxb2-basics:0.11.0',
jaxb2_basics_ant: 'org.jvnet.jaxb2_commons:jaxb2-basics-ant:0.11.0',
jaxb2_basics: 'org.jvnet.jaxb2_commons:jaxb2-basics:0.12.0',
jaxb2_basics_ant: 'org.jvnet.jaxb2_commons:jaxb2-basics-ant:0.12.0',

geolatte: "org.geolatte:geolatte-geom:${geolatteVersion}",

Expand Down
4 changes: 3 additions & 1 deletion hibernate-core/hibernate-core.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ jar {
'javax.enterprise.inject.spi;resolution:=optional',
'javax.inject;resolution:=optional',
'net.bytebuddy.*;resolution:=optional',
'javax.xml.bind.*'
// We must specify the version explicitly to allow Karaf
// to use an older version of JAXB (the only one we can use in Karaf)
"javax.xml.bind.*;version=\"${project.jaxbApiVersionOsgiRange}\""

// // TODO: Uncomment once EntityManagerFactoryBuilderImpl no longer
// // uses ClassLoaderServiceImpl.
Expand Down

0 comments on commit aa2648d

Please sign in to comment.