-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build warnings. Add docker build #41
Open
tomers
wants to merge
111
commits into
c-icap:master
Choose a base branch
from
tomers:build-system-0_5_x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1278 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1279 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1281 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1282 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
…returned header value git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1287 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
…object Using ci_simple_file_to_const_string or ci_simple_file_to_membuf may result to c-icap crash due to uninitialised ci_simple_file_t members. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1288 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1290 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1294 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Author: [email protected] git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1297 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Still some work required to remove depedencies from deprecated openSSL API functions git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1305 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Calling setgroups to set supplementary group IDs required before before call setgid. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1306 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1307 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
USE_POSIX_MAPPED_FILES is not defined In the case the USE_POSIX_MAPPED_FILES is nof defined just return NULL. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1308 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
The info module does not return all statistics to the client because of a wrongly terminated ci_membuf structure git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1309 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Author: "Trever L. Adams" <[email protected]> git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1312 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Author: Jeffrey Merkey <[email protected]> This is include the r1314, r1315, r1317 and r1318 patches from trunk git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1323 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1325 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Fixes to: - Allow build on different directory than the sources directory. eg # mkdir /tmp/c-icap-build # cd /tmp/c-icap-build # /path/to/c-icap/sources/configure # make - Add the -enable-rpath option to configure script to allow build c-icap using the -rpath option for the libraries does not exist to standard directories. The c-icap itself always uses the -rpath option for the location where the icapapi library is installed. The libtool adds the rpath in this case, and looks that there is not any option to disable it. - Fix BerkeleyDB detection - It should fix build problems reported for the cases where one or more libraries are not installed under the standard directories. Still maybe there are problems with external libraries and their depedencies, but looks impossible to find a way to safelly cover all of the cases. In the worst case the users can always use the LD_LIBRARY_PATH with configure and make. This is include r1320, r1321 trunk patches. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1326 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
When the deflate encoded data are not enough to produce a single byte of uncompressed data c-icap will crash on an assertion failure. This patch removes the assert calls from decompressing code and just return errors from related functions. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1327 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1328 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1348 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
The TLS server should use the latest available method for security reasons. Users can disable one or more TLS versions using the SSL_OP_NO_TLS* and SSL_OP_NO_SSLv* tls options. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1361 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
…sequence when sends zero sized files r1351 and r1352 commits from trunk git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1362 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Author: "Trever L. Adams" <[email protected]> git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1363 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1364 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1366 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
Author: "Trever L. Adams" <[email protected]> git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1368 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1369 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
…sequence when sends zero sized files Commit r1362 has wrong title actually fix "brotli zero sized files problem" git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1373 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
- Brotli decoding using ci_uncompress_preview fails in many (most?) cases - c-icap does not handle correctlyi brotli decompressed object which exceeds the maximum allowed. - The brotli decompression errors are not reported to the related API calls callers and the services which depends on interpreting such errors ( eg virus_scan) fails to correctly handle brotli decompression errors. git-svn-id: https://svn.code.sf.net/p/c-icap/code/c-icap-server/branches/c_icap_0_5_x@1376 950cb5d8-81e4-40ab-8cb8-c719d5138fe1
- The "ServiceName.Allow206" does not work as expected: It supposed that it should disable the 206 allow flag on requests if it is set to "off". However it tries to disable (unsuccessfully in most cases) the 206 requests when this is set to "on" or whatever different to "off". - When the ci_service_enable_206 is used in mod_init_service handler The ServiceName.Allow206 does not have any effect. - The client code does not parse correctly the "Allow: ..., 206, ... " header
The c-icap kids must be shutdown if the master process, which controls their operation is gone for a reason, if the select is used instead of poll. The select system call if the other end of the pipe is gone retun a read event and the next read call will return error. The c-icap unfortunatelly does not hande this case well.
This is because of a bug in ci_thread_mutex handling code.
... after commit "Check ldap_get_values_len call for NULL ..."
The c-icap prints this message and abort transaction. The bug actually exists in c-icap side: - The c-icap gets data from client and calls service io function - The service accepts a part of the data, the c-icap expects to retrieve some data from service (senting is not locked) but for a reason the service does not sent any data. - The c-icap prints the error message and abort transaction.
... when the g++ compiler is used.
Fixes c-icap#19 github issue.
Fixed c-icap#21 github issue
Add missing initialization of free_test_data field in ci_acl_typelist_add. This bug can cause segmentation faults in the wort case or at least memory leaks when the *_header acls are used. Also fixes the c-icap#18 github issue.
... part 2. add a missing ';'
Equivalent to mster branch commit 284b60b
This patch fix a released memory access while the ci_mem_allocator_destroy is called for an object built using the ci_serial_allocator method.
…NDEMAND command types - The CI_CMD_POST_CONFIG commands are executed after the configuration file is parsed. - The CI_CMD_MONITOR_START commands are executed on master process after the children are started and just before the monitoring of commands socket and monitoring of children preocesses are started. - The CI_CMD_MONITOR_ONDEMAN commands are executed on master process. They can be scheduled using the ci_command_schedule or ci_command_schedule_on functions on services or modules initialization functions (while c-icap starts and before kids started) and will be executed only on master process. Also this patch (the 0.5.x variance of the patch) adds the new CI_CMD_* defines/names for commands.
may not executed While the CI_CMD_MONITOR_ONDEMAN commands types are checked on master/monitor process any other commands in the queue stored the commands for future execution are removed. If commands of type CI_CMD_ONDEMAND are scheduled in modules/services initialization functions will not executed for the forked new children processes. This bug is added with the commit "The new CI_CMD_POST_CONFIG, CI_CMD_MONITOR_START and ..." which add support for some new commands types.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.