Fix two memory leaks related to ci_client_library #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a call to ci_cfg_lib_destroy to ci_client_library_release Added a free to pool_allocator_destroy to free the ci_mem_allocator_t's name that's created by strdup in ci_create_pool_allocator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While switching to 0.6 I came across two memory leaks when using ci_client_library_init()/_release().
The strdup call in mem.c:1026 is never cleaned up.
ci_client_library_init calls ci_cfg_lib_init, but ci_client_library_release doesn't call ci_cfg_lib_destroy. As a result the cfg_params_allocator is never destroyed.