Make Part type aware of array or object target (solidjs#665)

c5soft · Oct 4, 2021 · 3f213df · 3f213df
1 parent 629203c
commit 3f213df
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/solid/store/src/store.ts b/packages/solid/store/src/store.ts
@@ -262,7 +262,11 @@ export type ArrayFilterFn<T> = (
   index: number
 ) => boolean;
 
-export type Part<T> = keyof T | Array<keyof T> | StorePathRange | ArrayFilterFn<T>; // changing this to "T extends any[] ? ArrayFilterFn<T> : never" results in depth limit errors
+export type Part<T> = T extends any[]
+  ? keyof T | Array<keyof T> | ArrayFilterFn<T> | StorePathRange
+  : T extends object
+  ? keyof T | Array<keyof T>
+  : never;
 
 export type NullableNext<T, K> = K extends keyof T
   ? T[K]