SAK-44722: SAMIGO - Uncategorized text is hardcoded (sakaiproject#8853)

cab938 · Nov 30, 2020 · ca3ec83 · ca3ec83
1 parent 5fb5b70
commit ca3ec83
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/...pp/src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages.properties b/...pp/src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages.properties
@@ -176,6 +176,7 @@ student_identity=Hide student identity from grader
 gradebook_options=Gradebook Options
 gradebook_options_help=Send assessment score to Gradebook immediately, regardless of options below
 gradebook_category_select=Select a Gradebook category (optional)
+gradebook_uncategorized=Uncategorized
 
 recorded_score=If multiple submissions, record the
 highest_score=highest score

diff --git a/...src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages_es.properties b/...src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages_es.properties
@@ -176,6 +176,7 @@ student_identity=Al calificar no se podr\u00e1 ver la identidad de cada estudian
 gradebook_options=Opciones de Calificaciones
 gradebook_options_help=Las notas se enviar\u00e1n inmediatamente a la herramienta  Calificaciones independientemente de las opciones seleccionadas a continuaci\u00f3n.
 gradebook_category_select=Seleccionar una categor\u00eda (opcional)
+gradebook_uncategorized=Sin categor\u00eda
 
 recorded_score=Puntuaci\u00f3n almacenada si existen varios env\u00edos por usuario
 highest_score=Guardar la puntuaci\u00f3n m\u00e1s alta

diff --git a/...-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java b/...-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
@@ -1821,7 +1821,7 @@ private List populateCategoriesSelectList() {
             String gradebookUid = toolManager.getCurrentPlacement().getContext();
             categoryDefinitions = gradebookService.getCategoryDefinitions(gradebookUid);
 
-            selectList.add(new SelectItem("-1","Uncategorized")); // -1 for a cat id means unassigned
+            selectList.add(new SelectItem("-1", assessmentSettingMessages.getString("gradebook_uncategorized"))); // -1 for a cat id means unassigned
             for (CategoryDefinition categoryDefinition: categoryDefinitions) {
                 selectList.add(new SelectItem(categoryDefinition.getId().toString(), categoryDefinition.getName()));
             }

diff --git a/...java/org/sakaiproject/tool/assessment/ui/bean/author/PublishedAssessmentSettingsBean.java b/...java/org/sakaiproject/tool/assessment/ui/bean/author/PublishedAssessmentSettingsBean.java
@@ -473,7 +473,7 @@ private List<SelectItem> populateCategoriesSelectList() {
       String gradebookUid = toolManager.getCurrentPlacement().getContext();
       categoryDefinitions = gradebookService.getCategoryDefinitions(gradebookUid);
 
-      selectList.add(new SelectItem("-1","Uncategorized")); // -1 for a cat id means unassigned
+      selectList.add(new SelectItem("-1", assessmentSettingMessages.getString("gradebook_uncategorized"))); // -1 for a cat id means unassigned
       for (CategoryDefinition categoryDefinition: categoryDefinitions) {
         selectList.add(new SelectItem(categoryDefinition.getId().toString(), categoryDefinition.getName()));
       }