fix loadfailure error (google#3742)

cabanier · Aug 25, 2022 · d3ba177 · d3ba177
1 parent ebae7e3
commit d3ba177
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/model-viewer/src/model-viewer-base.ts b/packages/model-viewer/src/model-viewer-base.ts
@@ -586,7 +586,8 @@ export default class ModelViewerElementBase extends ReactiveElement {
       const detail = {url: source};
       this.dispatchEvent(new CustomEvent('preload', {detail}));
     } catch (error) {
-      this.dispatchEvent(new CustomEvent('error', {detail: error}));
+      this.dispatchEvent(new CustomEvent(
+          'error', {detail: {type: 'loadfailure', sourceError: error}}));
     } finally {
       requestAnimationFrame(() => {
         requestAnimationFrame(() => {

diff --git a/packages/model-viewer/src/test/model-viewer-base-spec.ts b/packages/model-viewer/src/test/model-viewer-base-spec.ts
@@ -158,7 +158,9 @@ suite('ModelViewerElementBase', () => {
       test('eventually dispatches an error event', async () => {
         const sourceErrors = waitForEvent(element, 'error');
         element.src = './does-not-exist.glb';
-        await sourceErrors;
+        const event = await sourceErrors;
+
+        expect((event as any).detail.type).to.be.eq('loadfailure');
       });
     });