Skip to content

Commit

Permalink
Merge PR cosmos#5392: Fix typos in the CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
ardaguclu authored and alexanderbez committed Dec 12, 2019
1 parent d58bf90 commit a7e28de
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ contributors, the general procedure for contributing has been established:
[find](https://github.com/cosmos/cosmos-sdk/issues) an issue you'd like to help with
2. Participate in thoughtful discussion on that issue
3. If you would like to contribute:
1. If a the issue is a proposal, ensure that the proposal has been accepted
2. Ensure that nobody else has already begun working on this issue, if they have
1. If the issue is a proposal, ensure that the proposal has been accepted
2. Ensure that nobody else has already begun working on this issue. If they have,
make sure to contact them to collaborate
3. If nobody has been assigned the issue and you would like to work on it
3. If nobody has been assigned for the issue and you would like to work on it,
make a comment on the issue to inform the community of your intentions
to begin work
4. Follow standard Github best practices: fork the repo, branch from the
Expand Down Expand Up @@ -120,15 +120,15 @@ To pull in updates from the origin repo, run
- `git fetch upstream`
- `git rebase upstream/master` (or whatever branch you want)

Please don't make Pull Requests to `master`.
Please don't make Pull Requests from `master`.

## Dependencies

We use [Go 1.11 Modules](https://github.com/golang/go/wiki/Modules) to manage
dependency versions.

The master branch of every Cosmos repository should just build with `go get`,
which means they should be kept up-to-date with their dependencies so we can
which means they should be kept up-to-date with their dependencies, so we can
get away with telling people they can just `go get` our software.

Since some dependencies are not under our control, a third party may break our
Expand Down

0 comments on commit a7e28de

Please sign in to comment.