Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to triava cache v1.0.4 #7

Closed
wants to merge 2 commits into from

Conversation

christian-esken
Copy link
Contributor

@christian-esken christian-esken commented Sep 11, 2017

Update to triava v1.0.4

  • Follow last API changes between 0.9.5 and 1.0
  • Fix omissions for triava in the JMH tests

README updates

Christian Esken added 2 commits September 11, 2017 10:53
- Follow last API changes between 0.9 and 1.0
- Fix omissions for triava in the JMH tests
@christian-esken
Copy link
Contributor Author

christian-esken commented Sep 11, 2017

Side note. The README should also reflect that running as root may be required, as it writes to an output directory /run/shm/jmh-result/ . That directory could not be created as ordinary user for me so the test run failed. Also running as root is beneficial for not interrupting the test with entering passwords for limitCoreCount.sh.

I propose this addition. I did not commit that, as I was not sure where the best position in the README would be. Also I would rather see that the result is written locally to ./jmh-result/

This should be run as root, for writing to the output directory /run/shm/jmh-result/ , and to limit the core count via ./limitCoreCount.sh

@cruftex
Copy link
Member

cruftex commented Sep 11, 2017

Hi Christian,

thanks for the update. I am in vacation for two weeks and need to look into that later.

I am a little clueless about the shell "glue code". Depending on the environment and the benchmark aims, there will always need to be some modifications necessary. I see the jmh-run.sh more as an example rather then something that should run OOTB.

@christian-esken
Copy link
Contributor Author

OK. A small hint in the README would be sufficent then. Lets discuss details later. Have a nice vacation.

@cruftex
Copy link
Member

cruftex commented Dec 30, 2021

Closing outdated PR

@cruftex cruftex closed this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants