Skip to content

Commit

Permalink
[WATCHDOG] wdt_pci - use pci_request_region
Browse files Browse the repository at this point in the history
Use pci_request_region instead of request_region for this pci_driver.

Signed-off-by: Wim Van Sebroeck <[email protected]>
  • Loading branch information
Wim Van Sebroeck committed Sep 18, 2009
1 parent d7e9791 commit 119d3e5
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions drivers/watchdog/wdt_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -647,14 +647,15 @@ static int __devinit wdtpci_init_one(struct pci_dev *dev,
goto out_pci;
}

irq = dev->irq;
io = pci_resource_start(dev, 2);

if (request_region(io, 16, "wdt_pci") == NULL) {
printk(KERN_ERR PFX "I/O address 0x%04x already in use\n", io);
if (pci_request_region(dev, 2, "wdt_pci")) {
printk(KERN_ERR PFX "I/O address 0x%04x already in use\n",
pci_resource_start(dev, 2));
goto out_pci;
}

irq = dev->irq;
io = pci_resource_start(dev, 2);

if (request_irq(irq, wdtpci_interrupt, IRQF_DISABLED | IRQF_SHARED,
"wdt_pci", &wdtpci_miscdev)) {
printk(KERN_ERR PFX "IRQ %d is not free\n", irq);
Expand Down Expand Up @@ -717,7 +718,7 @@ static int __devinit wdtpci_init_one(struct pci_dev *dev,
out_irq:
free_irq(irq, &wdtpci_miscdev);
out_reg:
release_region(io, 16);
pci_release_region(dev, 2);
out_pci:
pci_disable_device(dev);
goto out;
Expand All @@ -733,7 +734,7 @@ static void __devexit wdtpci_remove_one(struct pci_dev *pdev)
misc_deregister(&temp_miscdev);
unregister_reboot_notifier(&wdtpci_notifier);
free_irq(irq, &wdtpci_miscdev);
release_region(io, 16);
pci_release_region(pdev, 2);
pci_disable_device(pdev);
dev_count--;
}
Expand Down

0 comments on commit 119d3e5

Please sign in to comment.