Skip to content

Commit

Permalink
clk: meson: add ROUND_CLOSEST to the pll driver
Browse files Browse the repository at this point in the history
Provide an option for the pll driver to round to the rate closest to the
requested rate, instead of systematically rounding down.

This may allow the provided rate to be closer to the requested rate when
rounding up is not an issue

Signed-off-by: Jerome Brunet <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
  • Loading branch information
jbrun3t authored and superna9999 committed Mar 13, 2018
1 parent c77de0e commit 0a1be86
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
17 changes: 13 additions & 4 deletions drivers/clk/meson/clk-pll.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ static u16 __pll_params_with_frac(unsigned long rate,
u64 val = (u64)rate * pllt->n;

val <<= pllt->od + pllt->od2 + pllt->od3;
val = div_u64(val * frac_max, parent_rate);

if (pll->flags & CLK_MESON_PLL_ROUND_CLOSEST)
val = DIV_ROUND_CLOSEST_ULL(val * frac_max, parent_rate);
else
val = div_u64(val * frac_max, parent_rate);

val -= pllt->m * frac_max;

return min((u16)val, (u16)(frac_max - 1));
Expand All @@ -125,9 +130,13 @@ meson_clk_get_pll_settings(unsigned long rate,
while (table[i].rate && table[i].rate <= rate)
i++;

/* Select the setting of the rounded down rate */
if (i != 0)
i--;
if (i != 0) {
if (MESON_PARM_APPLICABLE(&pll->frac) ||
!(pll->flags & CLK_MESON_PLL_ROUND_CLOSEST) ||
(abs(rate - table[i - 1].rate) <
abs(rate - table[i].rate)))
i--;
}

return (struct pll_rate_table *)&table[i];
}
Expand Down
2 changes: 2 additions & 0 deletions drivers/clk/meson/clkc.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ struct pll_rate_table {
.od = (_od), \
}

#define CLK_MESON_PLL_ROUND_CLOSEST BIT(0)

struct meson_clk_pll_data {
struct parm m;
struct parm n;
Expand Down

0 comments on commit 0a1be86

Please sign in to comment.