tracing: Missing error code in tracer_alloc_buffers()

If ring_buffer_alloc() or one of the next couple function calls fail then we should return -ENOMEM but the current code returns success. Link: http://lkml.kernel.org/r/20170801110201.ajdkct7vwzixahvx@mwanda Cc: Sebastian Andrzej Siewior <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: [email protected] Fixes: b32614c ('tracing/rb: Convert to hotplug state machine') Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
cail · Aug 2, 2017 · 147d88e · 147d88e
1 parent 4bb0f0e
commit 147d88e
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
@@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void)
 	if (ret < 0)
 		goto out_free_cpumask;
 	/* Used for event triggers */
+	ret = -ENOMEM;
 	temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE);
 	if (!temp_buffer)
 		goto out_rm_hp_state;