Skip to content

Commit

Permalink
cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add()
Browse files Browse the repository at this point in the history
The 'group_changed' variable is initialized to 0 and never changed, so
checking the variable is meaningless.

It is a leftover from 0bbfeb8 ("cfq-iosched: Always provide group
iosolation."). Let's get rid of it.

Signed-off-by: Namhyung Kim <[email protected]>
Cc: Justin TerAvest <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
namhyung authored and Jens Axboe committed May 24, 2011
1 parent 229836b commit 20359f2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
struct cfq_rb_root *service_tree;
int left;
int new_cfqq = 1;
int group_changed = 0;

service_tree = service_tree_for(cfqq->cfqg, cfqq_prio(cfqq),
cfqq_type(cfqq));
Expand Down Expand Up @@ -1350,7 +1349,7 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
rb_link_node(&cfqq->rb_node, parent, p);
rb_insert_color(&cfqq->rb_node, &service_tree->rb);
service_tree->count++;
if ((add_front || !new_cfqq) && !group_changed)
if (add_front || !new_cfqq)
return;
cfq_group_notify_queue_add(cfqd, cfqq->cfqg);
}
Expand Down

0 comments on commit 20359f2

Please sign in to comment.