Skip to content

Commit

Permalink
perf stat: Do not clean event's private stats
Browse files Browse the repository at this point in the history
Mel reported stddev reporting was broken due to following commit:

	106a94a ("perf stat: Introduce read_counters function")

This commit merged interval and overall counters reading into single
read_counters function.

The old interval code cleaned the stddev data for some reason (it's
never displayed in interval mode) and the mentioned commit kept on
cleaning the stddev data in merged function, which resulted in the
stddev not being displayed.

Removing the wrong stddev data cleanup init_stats call.

Reported-and-Tested-by: Mel Gorman <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: [email protected] # v4.2+
Fixes: 106a94a ("perf stat: Introduce read_counters function")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
olsajiri authored and acmel committed Jan 26, 2016
1 parent 0805909 commit 3f416f2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/perf/util/stat.c
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
int i, ret;

aggr->val = aggr->ena = aggr->run = 0;
init_stats(ps->res_stats);

if (counter->per_pkg)
zero_per_pkg(counter);
Expand Down

0 comments on commit 3f416f2

Please sign in to comment.