checkpatch: struct seq_operations should normally be const

In the general use case struct seq_operations should be a const object. Check for and warn where it is not. Cc: Ingo Molnar <[email protected]> Signed-off-by: Andy Whitcroft <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
cail · Jan 16, 2009 · 6903ffb · 6903ffb
1 parent 3966778
commit 6903ffb
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -2527,9 +2527,10 @@ sub process {
 			WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
 		}
 # check for struct file_operations, ensure they are const.
-		if ($line =~ /\bstruct\s+file_operations\b/ &&
-		    $line !~ /\bconst\b/) {
-			WARN("struct file_operations should normally be const\n" . $herecurr);
+		if ($line !~ /\bconst\b/ &&
+		    $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
+			WARN("struct $1 should normally be const\n" .
+				$herecurr);
 		}
 
 # use of NR_CPUS is usually wrong