Skip to content

Commit

Permalink
KVM: PIC: fix use of uninitialised variable.
Browse files Browse the repository at this point in the history
Commit aea218f (KVM: PIC: call ack notifiers for irqs that are
dropped form irr) used an uninitialised variable to track whether an
appropriate apic had been found.  This could result in calling the ack
notifier incorrectly.

Cc: Gleb Natapov <[email protected]>
Cc: Avi Kivity <[email protected]>
Signed-off-by: Jamie Iles <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
  • Loading branch information
jamieiles authored and avikivity committed Sep 4, 2012
1 parent 5b716ac commit 749c59f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kvm/i8259.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ static void pic_ioport_write(void *opaque, u32 addr, u32 val)
if (val & 0x10) {
u8 edge_irr = s->irr & ~s->elcr;
int i;
bool found;
bool found = false;
struct kvm_vcpu *vcpu;

s->init4 = val & 1;
Expand Down

0 comments on commit 749c59f

Please sign in to comment.