Skip to content

Commit

Permalink
batman-adv: Combine two seq_puts() calls into one call in batadv_nc_n…
Browse files Browse the repository at this point in the history
…odes_seq_print_text()

A bit of text was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
Signed-off-by: Sven Eckelmann <[email protected]>
Signed-off-by: Simon Wunderlich <[email protected]>
  • Loading branch information
elfring authored and simonwunderlich committed May 23, 2017
1 parent 626caae commit 912eeed
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/batman-adv/network-coding.c
Original file line number Diff line number Diff line change
Expand Up @@ -1935,9 +1935,7 @@ int batadv_nc_nodes_seq_print_text(struct seq_file *seq, void *offset)
list)
seq_printf(seq, "%pM ",
nc_node->addr);
seq_puts(seq, "\n");

seq_puts(seq, " Outgoing: ");
seq_puts(seq, "\n Outgoing: ");
/* For out_nc_node to this orig_node */
list_for_each_entry_rcu(nc_node,
&orig_node->out_coding_list,
Expand Down

0 comments on commit 912eeed

Please sign in to comment.