Skip to content

Commit

Permalink
e1000e: Set HTHRESH when PTHRESH is used
Browse files Browse the repository at this point in the history
According to section 12.0.3.4.13 "Receive Descriptor Control - RXDCTL"
of the Intel® 82579 Gigabit Ethernet PHY Datasheet v2.1:

    "HTHRESH should be given a non zero value when ever PTHRESH is
     used."

In RXDCTL(0), PTHRESH lives at bits 5:0, and HTHREST lives at bits 13:8.
Set only bit 8 of HTHREST as is done in e1000_flush_rx_ring(). Found by
inspection.

Signed-off-by: Matt Turner <[email protected]>
Tested-by: Aaron Brown <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>
  • Loading branch information
Matt Turner authored and Jeff Kirsher committed Jan 24, 2018
1 parent 28cb2d1 commit b701cac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/intel/e1000e/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -3303,7 +3303,7 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
if (adapter->flags & FLAG_IS_ICH) {
u32 rxdctl = er32(RXDCTL(0));

ew32(RXDCTL(0), rxdctl | 0x3);
ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
}

pm_qos_update_request(&adapter->pm_qos_req, lat);
Expand Down

0 comments on commit b701cac

Please sign in to comment.