Skip to content

Commit

Permalink
b43: use kernel api to replace b43 specific helper function
Browse files Browse the repository at this point in the history
Use ieee80211_channel_to_frequency() to replace b43_channel_to_freq_{2,5}ghz(),
and remove unused b43_freq_to_channel_{2,5}ghz().

Signed-off-by: ZHAO Gang <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
zhao-gang authored and linvjw committed Feb 13, 2014
1 parent 0e028ab commit bb6bd25
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 41 deletions.
35 changes: 0 additions & 35 deletions drivers/net/wireless/b43/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,41 +58,6 @@ enum b43_verbosity {
#endif
};


/* Lightweight function to convert a frequency (in Mhz) to a channel number. */
static inline u8 b43_freq_to_channel_5ghz(int freq)
{
return ((freq - 5000) / 5);
}
static inline u8 b43_freq_to_channel_2ghz(int freq)
{
u8 channel;

if (freq == 2484)
channel = 14;
else
channel = (freq - 2407) / 5;

return channel;
}

/* Lightweight function to convert a channel number to a frequency (in Mhz). */
static inline int b43_channel_to_freq_5ghz(u8 channel)
{
return (5000 + (5 * channel));
}
static inline int b43_channel_to_freq_2ghz(u8 channel)
{
int freq;

if (channel == 14)
freq = 2484;
else
freq = 2407 + (5 * channel);

return freq;
}

static inline int b43_is_cck_rate(int rate)
{
return (rate == B43_CCK_RATE_1MB ||
Expand Down
12 changes: 6 additions & 6 deletions drivers/net/wireless/b43/xmit.c
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,8 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr)
B43_WARN_ON(1);
/* FIXME: We don't really know which value the "chanid" contains.
* So the following assignment might be wrong. */
status.freq = b43_channel_to_freq_5ghz(chanid);
status.freq =
ieee80211_channel_to_frequency(chanid, status.band);
break;
case B43_PHYTYPE_G:
status.band = IEEE80211_BAND_2GHZ;
Expand All @@ -819,13 +820,12 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr)
case B43_PHYTYPE_HT:
/* chanid is the SHM channel cookie. Which is the plain
* channel number in b43. */
if (chanstat & B43_RX_CHAN_5GHZ) {
if (chanstat & B43_RX_CHAN_5GHZ)
status.band = IEEE80211_BAND_5GHZ;
status.freq = b43_channel_to_freq_5ghz(chanid);
} else {
else
status.band = IEEE80211_BAND_2GHZ;
status.freq = b43_channel_to_freq_2ghz(chanid);
}
status.freq =
ieee80211_channel_to_frequency(chanid, status.band);
break;
default:
B43_WARN_ON(1);
Expand Down

0 comments on commit bb6bd25

Please sign in to comment.