Skip to content

Commit

Permalink
[PATCH] fork.c: proc_fork_connector() called under write_lock()
Browse files Browse the repository at this point in the history
Don't do that - it does GFP_KERNEL allocations, for a start.

(Reported by Guillaume Thouvenin <[email protected]>)

Acked-by: Matt Helsley <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Nov 28, 2005
1 parent ff88a3b commit c13cf85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/fork.c
Original file line number Diff line number Diff line change
Expand Up @@ -1135,13 +1135,13 @@ static task_t *copy_process(unsigned long clone_flags,
__get_cpu_var(process_counts)++;
}

proc_fork_connector(p);
if (!current->signal->tty && p->signal->tty)
p->signal->tty = NULL;

nr_threads++;
total_forks++;
write_unlock_irq(&tasklist_lock);
proc_fork_connector(p);
retval = 0;

fork_out:
Expand Down

0 comments on commit c13cf85

Please sign in to comment.