Skip to content

Commit

Permalink
MIPS: uprobes: Remove __weak attribute from arch_uprobe_copy_ixol.
Browse files Browse the repository at this point in the history
Arch-specific implementation of arch_uprobe_copy_ixol is expected to
override the weak implementation in generic code.
As currently both implementations are marked as weak, it is up to the
linker to chose one. Remove the __weak attribute from MIPS code to make
sure the correct version is used.

Fixes: 40e084a ("MIPS: Add uprobes support.")
Signed-off-by: Marcin Nowakowski <[email protected]>
Cc: [email protected]
Patchwork: https://patchwork.linux-mips.org/patch/14660/
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
MJNowakowski authored and ralfbaechle committed Jan 3, 2017
1 parent 9c48568 commit cd854fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/mips/kernel/uprobes.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ int __weak set_swbp(struct arch_uprobe *auprobe, struct mm_struct *mm,
return uprobe_write_opcode(mm, vaddr, UPROBE_SWBP_INSN);
}

void __weak arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,
void arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,
void *src, unsigned long len)
{
unsigned long kaddr, kstart;
Expand Down

0 comments on commit cd854fc

Please sign in to comment.