Skip to content

Commit

Permalink
Fix Python wheel generation
Browse files Browse the repository at this point in the history
We were seeing this error when importing the `thrift` package:

    Repairing wheel artifactory-0.1.17-py3-none-any.whl
    INFO:auditwheel.main_show:This does not look like a platform wheel, no ELF executable or shared library file (including compiled Python C extension) found in the wheel archive
    Assuming artifactory-0.1.17-py3-none-any.whl is a non-platform wheel. Skipping.
    Repairing wheel thrift-0.16.0-cp310-cp310-linux_x86_64.whl

    thrift-0.16.0-cp310-cp310-linux_x86_64.whl is consistent with the
    following platform tag: "manylinux_2_34_x86_64".

    The wheel references external versioned symbols in these
    system-provided shared libraries: libgcc_s.so.1 with versions
    {'GCC_3.0'}, libc.so.6 with versions {'GLIBC_2.2.5'}, libstdc++.so.6
    with versions {'CXXABI_1.3', 'GLIBCXX_3.4.29', 'GLIBCXX_3.4'}

    This constrains the platform tag to "manylinux_2_34_x86_64". In order
    to achieve a more compatible tag, you would need to recompile a new
    wheel from source on a system with earlier versions of these
    libraries, such as a recent manylinux image.
    INFO:auditwheel.main_repair:Repairing thrift-0.16.0-cp310-cp310-linux_x86_64.whl
    usage: auditwheel [-h] [-V] [-v] command ...
    auditwheel: error: cannot repair "/opt/971_build/wheelhouse_tmp/thrift-0.16.0-cp310-cp310-linux_x86_64.whl" to "manylinux_2_31_x86_64" ABI because of the presence of too-recent versioned symbols. You'll need to compile the wheel on an older toolchain.

The issue here is that we were trying to achieve `manylinux_2.31`
compatibility. That's not really possible when you compile against the
system glibc in an Ubuntu 22.04 container. So the solution here is to
bump the compatibility requirement for the version of glibc in Ubuntu
22.04.

Change-Id: If5d7b09ec2db7473a1eb5b8a42e8d1b61e095df4
Signed-off-by: James Kuszmaul <[email protected]>
  • Loading branch information
philsc authored and AustinSchuh committed May 11, 2024
1 parent 257053b commit 43fe176
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/python/mirror_pip_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import requests
from pkginfo import Wheel

PLAT = "manylinux_2_31"
PLAT = "manylinux_2_34"
ARCH = "x86_64"
WHEELHOUSE_MIRROR_URL = "https://software.frc971.org/Build-Dependencies/wheelhouse"
PY_DEPS_WWWW_DIR = "/var/www/html/files/frc971/Build-Dependencies/wheelhouse"
Expand Down

0 comments on commit 43fe176

Please sign in to comment.