crypto: qce - fix uaf on qce_aead_register_one

Pointer alg points to sub field of tmpl, it is dereferenced after tmpl is freed. Fix this by accessing alg before free tmpl. Fixes: 9363efb ("crypto: qce - Add support for AEAD algorithms") Signed-off-by: Chengfeng Ye <[email protected]> Acked-by: Thara Gopinath <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
caleberi · Nov 20, 2021 · 4a9dbd0 · 4a9dbd0
1 parent 574c833
commit 4a9dbd0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/crypto/qce/aead.c b/drivers/crypto/qce/aead.c
@@ -802,8 +802,8 @@ static int qce_aead_register_one(const struct qce_aead_def *def, struct qce_devi
 
 	ret = crypto_register_aead(alg);
 	if (ret) {
-		kfree(tmpl);
 		dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);
+		kfree(tmpl);
 		return ret;
 	}