Skip to content

Commit

Permalink
lib: remove MODULE_LICENSE in non-modules
Browse files Browse the repository at this point in the history
Since commit 8b41fc4 ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Acked-by: Jacob Keller <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Jacob Keller <[email protected]>
Signed-off-by: Luis Chamberlain <[email protected]>
  • Loading branch information
nickalcock authored and mcgrof committed Apr 13, 2023
1 parent b084019 commit 5e0266f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/pldmfw/pldmfw.c
Original file line number Diff line number Diff line change
Expand Up @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const struct firmware *fw)
EXPORT_SYMBOL(pldmfw_flash_image);

MODULE_AUTHOR("Jacob Keller <[email protected]>");
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("PLDM firmware flash update library");

0 comments on commit 5e0266f

Please sign in to comment.