Skip to content

Commit

Permalink
async: simplify lowest_in_progress()
Browse files Browse the repository at this point in the history
The code in lowest_in_progress() are duplicated in two branches,
simplify them.

tj: Minor indentation adjustment.

Signed-off-by: Lai Jiangshan <[email protected]>
Signed-off-by: Tejun Heo <[email protected]>
Cc: Arjan van de Ven <[email protected]>
  • Loading branch information
Lai Jiangshan authored and htejun committed Mar 12, 2013
1 parent 6dbe51c commit 92266d6
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions kernel/async.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,24 +84,20 @@ static atomic_t entry_count;

static async_cookie_t lowest_in_progress(struct async_domain *domain)
{
struct async_entry *first = NULL;
struct list_head *pending;
async_cookie_t ret = ASYNC_COOKIE_MAX;
unsigned long flags;

spin_lock_irqsave(&async_lock, flags);

if (domain) {
if (!list_empty(&domain->pending))
first = list_first_entry(&domain->pending,
struct async_entry, domain_list);
} else {
if (!list_empty(&async_global_pending))
first = list_first_entry(&async_global_pending,
struct async_entry, global_list);
}
if (domain)
pending = &domain->pending;
else
pending = &async_global_pending;

if (first)
ret = first->cookie;
if (!list_empty(pending))
ret = list_first_entry(pending, struct async_entry,
domain_list)->cookie;

spin_unlock_irqrestore(&async_lock, flags);
return ret;
Expand Down

0 comments on commit 92266d6

Please sign in to comment.