Skip to content

Commit

Permalink
net: page_pool: fix warning code
Browse files Browse the repository at this point in the history
WARN_ON_ONCE("string") doesn't really do what appears to
be intended, so fix that.

Signed-off-by: Johannes Berg <[email protected]>
Fixes: 90de47f ("page_pool: fragment API support for 32-bit arch with 64-bit DMA")
Link: https://patch.msgid.link/20240705134221.2f4de205caa1.I28496dc0f2ced580282d1fb892048017c4491e21@changeid
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
jmberg-intel authored and kuba-moo committed Jul 9, 2024
1 parent e0ee68a commit 946b6c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/page_pool.c
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem)
return true;

unmap_failed:
WARN_ON_ONCE("unexpected DMA address, please report to netdev@");
WARN_ONCE(1, "unexpected DMA address, please report to netdev@");
dma_unmap_page_attrs(pool->p.dev, dma,
PAGE_SIZE << pool->p.order, pool->p.dma_dir,
DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING);
Expand Down

0 comments on commit 946b6c4

Please sign in to comment.