forked from facebook/hermes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Increase stack size for worker (runtime) thread
Summary: Running AsyncDebuggerAPITest with ASAN enabled causes a bunch of "call stack size exceeded" errors. Fixing this by switching to use pthread and set the stack size of the runtime thread to be the same as the main test runner thread. The runtime thread can be thought of as HermesRuntime's main thread and needs more stack space. ``` ******************** TEST 'Hermes-Unit :: API/./APITests/AsyncDebuggerAPITest.NoDebuggerEventCallbackTest' FAILED ******************** Note: Google Test filter = AsyncDebuggerAPITest.NoDebuggerEventCallbackTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from AsyncDebuggerAPITest [ RUN ] AsyncDebuggerAPITest.NoDebuggerEventCallbackTest libc++abi: terminating due to uncaught exception of type facebook::jsi::JSError: Maximum call stack size exceeded (native stack depth) RangeError: Maximum call stack size exceeded (native stack depth) ``` Reviewed By: mattbfb Differential Revision: D53145701 fbshipit-source-id: 378c4ce7580d786522bf63f904f2acf088b169dd
- Loading branch information
1 parent
79d16ca
commit 71037bd
Showing
4 changed files
with
58 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters