Skip to content

Commit

Permalink
fix: disable code-signing in development (#58)
Browse files Browse the repository at this point in the history
### Summary

Disabled `CodeSigningPlugin` in development which should allow for nice
& smooth dev experience again
  • Loading branch information
jbroma authored Aug 8, 2023
1 parent 924a53b commit 5bbc99b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/auth/webpack.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ export default env => {
},
}),
new Repack.plugins.CodeSigningPlugin({
enabled: mode === 'production',
privateKeyPath: path.join('..', '..', 'code-signing.pem'),
outputPath: path.join('build', 'outputs', platform, 'remotes'),
}),
Expand Down
1 change: 1 addition & 0 deletions packages/booking/webpack.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ export default env => {
shared: deps,
}),
new Repack.plugins.CodeSigningPlugin({
enabled: mode === 'production',
privateKeyPath: path.join('..', '..', 'code-signing.pem'),
outputPath: path.join('build', 'outputs', platform, 'remotes'),
}),
Expand Down
1 change: 1 addition & 0 deletions packages/dashboard/webpack.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export default env => {
shared: deps,
}),
new Repack.plugins.CodeSigningPlugin({
enabled: mode === 'production',
privateKeyPath: path.join('..', '..', 'code-signing.pem'),
outputPath: path.join('build', 'outputs', platform, 'remotes'),
}),
Expand Down
2 changes: 1 addition & 1 deletion packages/host/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ ScriptManager.shared.addResolver(async (scriptId, caller) => {
query: {
platform: Platform.OS, // only needed in development
},
verifyScriptSignature: 'strict',
verifyScriptSignature: __DEV__ ? 'off' : 'strict',
};
});

Expand Down
1 change: 1 addition & 0 deletions packages/shopping/webpack.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ export default env => {
shared: deps,
}),
new Repack.plugins.CodeSigningPlugin({
enabled: mode === 'production',
privateKeyPath: path.join('..', '..', 'code-signing.pem'),
outputPath: path.join('build', 'outputs', platform, 'remotes'),
}),
Expand Down

0 comments on commit 5bbc99b

Please sign in to comment.