Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use correct representation of Coding object in mappings #457

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

korikuzma
Copy link
Member

close #456

  • bump disease normalizer version to pull in updated system IRIs
  • correct Coding representation
    • system MUST use iriReference, not a free-text label
    • code MUST use syntax defined by the system
    • id will use record concept_id
  • Removes SYSTEM_URI_TO_NAMESPACE mapping (since it's no longer needed)

close #456

* `system` MUST use `iriReference`, not a free-text label
* `code` MUST use syntax defined by the `system`
* `id` will use record `concept_id`
@korikuzma korikuzma added priority:high High priority bug Something isn't working labels Jan 19, 2025
@korikuzma korikuzma self-assigned this Jan 19, 2025
@korikuzma korikuzma added priority:medium Medium priority and removed priority:high High priority labels Jan 20, 2025
src/therapy/schemas.py Outdated Show resolved Hide resolved
@korikuzma korikuzma marked this pull request as ready for review January 29, 2025 15:49
@korikuzma korikuzma requested a review from jsstevenson January 29, 2025 15:49
@korikuzma korikuzma merged commit 14d113e into main Jan 29, 2025
15 checks passed
@korikuzma korikuzma deleted the issue-456 branch January 29, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding object in mappings is not being represented correctly
2 participants