Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(smtp): Add SMTP integration to 12 Factor #2199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alithethird
Copy link
Collaborator

This PR is related to 12 Factor SMTP PR.

Rationale

Some applications require an SMTP integration to send emails to their clients. This PR is a follow-up to the latest 12 Factor PR for adding SMTP integration.

Changes

  • Add commented-out SMTP relation required objects to extension charmcraft.yaml.j2 files.
  • Add references about SMTP into extension reference documents.
  • Add documentation about SMTP integration and generated environment variables
  • Add the smtp charm lib to the initializer.

Reviewers:
@jdkandersson
@javierdelapuente
@erinecon

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this part of the reference reusable! Some small comments from me :D

@medubelko medubelko requested review from jahn-junior and removed request for medubelko March 3, 2025 21:28
@medubelko
Copy link
Contributor

Leaving the TA review to @jahn-junior and @erinecon.

@alithethird alithethird requested a review from erinecon March 4, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants