Skip to content

Commit

Permalink
Remove PCRE dependency.
Browse files Browse the repository at this point in the history
  • Loading branch information
blp committed Feb 25, 2010
1 parent 89521e3 commit a26cc67
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 31 deletions.
7 changes: 0 additions & 7 deletions INSTALL.Linux
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ you will need the following software:
connections from an Open vSwitch to an OpenFlow controller. To
enable, configure with --enable-ssl=yes.

- libpcre, the Perl Compatible Regular Expression library, is
optional but recommended. Without it, OVSDB will not be able to
validate regular-expression based contraints.

To compile the kernel module, you must also install the following. If
you cannot build or install the kernel module, you may use the
userspace-only implementation, at a cost in performance. The
Expand Down Expand Up @@ -84,9 +80,6 @@ following software:
- libssl compatible with the libssl used for build, if OpenSSL was
used for the build.

- libpcre compatible with the libpcre used for build, if PCRE was
used for the build.

- The Linux kernel version configured as part of the build.

- For optional support of ingress policing, the "tc" program from
Expand Down
18 changes: 3 additions & 15 deletions m4/openvswitch.m4
Original file line number Diff line number Diff line change
Expand Up @@ -216,28 +216,16 @@ AC_DEFUN([OVS_CHECK_LINUX_VT_H],

dnl Checks for libpcre.
dnl
dnl ovsdb wants any reasonable version of libpcre (6.6 is what
dnl XenServer 5.5 has).
dnl
dnl ezio-term wants libpcre that supports the PCRE_PARTIAL feature,
dnl which is libpcre 7.2 or later.
AC_DEFUN([OVS_CHECK_PCRE],
[dnl Make sure that pkg-config is installed.
m4_pattern_forbid([PKG_CHECK_MODULES])
PKG_CHECK_MODULES([PCRE],
[libpcre >= 6.6],
[HAVE_PCRE=yes
PKG_CHECK_EXISTS([libpcre >= 7.2],
[HAVE_PCRE_PARTIAL=yes],
[HAVE_PCRE_PARTIAL=no])],
[HAVE_PCRE=no
HAVE_PCRE_PARTIAL=no])
AM_CONDITIONAL([HAVE_PCRE], [test "$HAVE_PCRE" = yes])
[libpcre >= 7.2],
[HAVE_PCRE_PARTIAL=yes],
[HAVE_PCRE_PARTIAL=no])
AM_CONDITIONAL([HAVE_PCRE_PARTIAL], [test "$HAVE_PCRE_PARTIAL" = yes])
if test "$HAVE_PCRE" = yes; then
AC_DEFINE([HAVE_PCRE], [1], [Define to 1 if libpcre is installed.])
fi
AC_SUBST([HAVE_PCRE])
AC_SUBST([HAVE_PCRE_PARTIAL])
])

Expand Down
6 changes: 3 additions & 3 deletions ovsdb/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ EXTRA_DIST += \
# ovsdb-tool
bin_PROGRAMS += ovsdb/ovsdb-tool
ovsdb_ovsdb_tool_SOURCES = ovsdb/ovsdb-tool.c
ovsdb_ovsdb_tool_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(PCRE_LIBS)
ovsdb_ovsdb_tool_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a
# ovsdb-tool.1
man_MANS += ovsdb/ovsdb-tool.1
DISTCLEANFILES += ovsdb/ovsdb-tool.1
Expand All @@ -43,7 +43,7 @@ EXTRA_DIST += ovsdb/ovsdb-tool.1.in
# ovsdb-client
bin_PROGRAMS += ovsdb/ovsdb-client
ovsdb_ovsdb_client_SOURCES = ovsdb/ovsdb-client.c
ovsdb_ovsdb_client_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS) $(PCRE_LIBS)
ovsdb_ovsdb_client_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS)
# ovsdb-client.1
man_MANS += ovsdb/ovsdb-client.1
DISTCLEANFILES += ovsdb/ovsdb-client.1
Expand All @@ -52,7 +52,7 @@ EXTRA_DIST += ovsdb/ovsdb-client.1.in
# ovsdb-server
sbin_PROGRAMS += ovsdb/ovsdb-server
ovsdb_ovsdb_server_SOURCES = ovsdb/ovsdb-server.c
ovsdb_ovsdb_server_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS) $(PCRE_LIBS)
ovsdb_ovsdb_server_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS)
# ovsdb-server.1
man_MANS += ovsdb/ovsdb-server.1
DISTCLEANFILES += ovsdb/ovsdb-server.1
Expand Down
1 change: 0 additions & 1 deletion tests/atlocal.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# -*- shell-script -*-
HAVE_OPENSSL='@HAVE_OPENSSL@'
HAVE_PCRE='@HAVE_PCRE@'
HAVE_PYTHON='@HAVE_PYTHON@'
PERL='@PERL@'
PYTHON='@PYTHON@'
2 changes: 1 addition & 1 deletion tests/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ tests_test_ovsdb_SOURCES = \
tests/idltest.c \
tests/idltest.h
EXTRA_DIST += tests/uuidfilt.pl
tests_test_ovsdb_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS) $(PCRE_LIBS)
tests_test_ovsdb_LDADD = ovsdb/libovsdb.a lib/libopenvswitch.a $(SSL_LIBS)

# idltest schema and IDL
OVSIDL_BUILT += tests/idltest.c tests/idltest.h tests/idltest.ovsidl
Expand Down
2 changes: 1 addition & 1 deletion utilities/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ utilities_ovs_openflowd_LDADD = \
$(SSL_LIBS)

utilities_ovs_vsctl_SOURCES = utilities/ovs-vsctl.c vswitchd/vswitch-idl.c
utilities_ovs_vsctl_LDADD = lib/libopenvswitch.a $(SSL_LIBS) $(PCRE_LIBS)
utilities_ovs_vsctl_LDADD = lib/libopenvswitch.a $(SSL_LIBS)

utilities_ovs_wdt_SOURCES = utilities/ovs-wdt.c

Expand Down
5 changes: 2 additions & 3 deletions vswitchd/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ vswitchd_ovs_vswitchd_LDADD = \
ofproto/libofproto.a \
lib/libsflow.a \
lib/libopenvswitch.a \
$(SSL_LIBS) \
$(PCRE_LIBS)
$(SSL_LIBS)

vswitchd_ovs_brcompatd_SOURCES = \
vswitchd/ovs-brcompatd.c \
vswitchd/vswitch-idl.c \
vswitchd/vswitch-idl.h

vswitchd_ovs_brcompatd_LDADD = lib/libopenvswitch.a $(SSL_LIBS) $(PCRE_LIBS)
vswitchd_ovs_brcompatd_LDADD = lib/libopenvswitch.a $(SSL_LIBS)

EXTRA_DIST += \
vswitchd/ovs-vswitchd.8.in \
Expand Down

0 comments on commit a26cc67

Please sign in to comment.