-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CaraML SDK - v0 #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated client sdk module
Caraml sdk
chore: sync models client sdk from Ref:
…ning, some failing
After the a3ff01e commit, test results are
|
All non integration tests passing now.
|
chore: sync routers client sdk from Ref:main
This reverts commit 18d8e43.
Turing wrapper code added to the PR. One test case failing, on first look, it seems to be an integration test which connects to turing server. Can be checked later.
|
… later to the client metadata to track app version
mbruner
reviewed
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating sdk from all Caraml apps.
As part of this PR, [TLDR]
CaraML SDK Structure
All SDK code of corresponding CaraML apps will be moved to models/routers/store packages.
common
package will have session, project, secrets related code. [Not in scope of this PR]Generate and Sync Open API code from caraml-dev/merlin, caraml-dev/turing repos.
A new workflow (
.github/workflows/caraml-sync-generated-client.yaml
) to clone the repo and generate python client using openapi-generator-cli. This workflow accepts the following inputs :!! NOTE: Turing needs to generate clients with
v5.1.1
for now, Using the latest produces the client sdk with different format causing errors. This can be addressed later.