Remove the scrooge contrib plugin. (pantsbuild#10127)

1.30.x is expected to be the last release in the Pants 1.x series. Pants 2.x will no longer support the v1 engine, meaning these tasks will no longer work.

For anyone who still needs this functionality, we will give instructions and a script for users to be able to keep using Pants 1.x and Pants 2.x side-by-side. Given enough user interest, we can also port this functionality to the v2 engine or help users to write a plugin.

[ci skip-rust-tests]
[ci skip-jvm-tests]

BUILD

@@ -13,11 +13,6 @@ files(
   sources = ["BUILD_ROOT"],
 )
 
-files(
-  name = 'build_tools',
-  sources = ['BUILD.tools'],
-)
-
 files(
   name = 'gitignore',
   sources = ['.gitignore'],

build-support/bin/packages.py

@@ -91,10 +91,6 @@ def core_packages() -> Set[Package]:
 
 def contrib_packages() -> Set[Package]:
     return {
-        Package(
-            "pantsbuild.pants.contrib.scrooge",
-            "contrib/scrooge/src/python/pants/contrib/scrooge:plugin",
-        ),
         Package(
             "pantsbuild.pants.contrib.mypy", "contrib/mypy/src/python/pants/contrib/mypy:plugin",
         ),

contrib/BUILD

@@ -5,7 +5,6 @@ target(
   name = 'plugins',
   dependencies = [
     'contrib/mypy/src/python/pants/contrib/mypy:plugin',
-    'contrib/scrooge/src/python/pants/contrib/scrooge:plugin',
   ]
 )
 

contrib/README.md

@@ -9,8 +9,7 @@ plugin APIs are used.
 
 Most new plugins should get their own top-level `contrib/` subdirectory although it may make sense
 to house the source code for related plugins under one top-level `contrib/` subdirectory.  The
-`contrib/scrooge` directory is an example of this and houses two plugin tasks that both use the same
-underlying [Scrooge](https://github.com/twitter/scrooge) tool.
+`contrib/mypy` directory is an example of this.
 
 Contrib plugins should generally follow 3 basic setup steps:
 

contrib/release_packages.sh

@@ -6,16 +6,6 @@
 # `PKG_$NAME` definition.
 #
 
-function pkg_scrooge_install_test() {
-  local version=$1
-  execute_packaged_pants_with_internal_backends \
-    --plugins="['pantsbuild.pants.contrib.scrooge==${version}']" \
-    --explain gen | grep "scrooge" &> /dev/null && \
-  execute_packaged_pants_with_internal_backends \
-    --plugins="['pantsbuild.pants.contrib.scrooge==${version}']" \
-    --explain lint | grep "thrift" &> /dev/null
-}
-
 function pkg_mypy_install_test() {
   local version=$1
   execute_packaged_pants_with_internal_backends \