MDL-66631 mod_forum: make get_from_discussion_ids use new fn

carlooos28 · Oct 18, 2019 · 6e23f29 · 6e23f29
1 parent 718d7a4
commit 6e23f29
Showing 1 changed file with 1 addition and 20 deletions.
diff --git a/mod/forum/classes/local/vaults/post.php b/mod/forum/classes/local/vaults/post.php
@@ -134,26 +134,7 @@ public function get_from_discussion_ids(
             return [];
         }
 
-        $alias = $this->get_table_alias();
-
-        list($insql, $params) = $this->get_db()->get_in_or_equal($discussionids, SQL_PARAMS_NAMED);
-        [
-            'where' => $privatewhere,
-            'params' => $privateparams,
-        ] = $this->get_private_reply_sql($user, $canseeprivatereplies);
-
-        $wheresql = "{$alias}.discussion {$insql} {$privatewhere}";
-
-        if ($orderby) {
-            $orderbysql = $alias . '.' . $orderby;
-        } else {
-            $orderbysql = '';
-        }
-
-        $sql = $this->generate_get_records_sql($wheresql, $orderbysql);
-        $records = $this->get_db()->get_records_sql($sql, array_merge($params, $privateparams));
-
-        return $this->transform_db_records_to_entities($records);
+        return $this->get_from_filters($user, ['discussionids' => $discussionids], $canseeprivatereplies, $orderby);
     }
 
     /**