MDL-40669 tool_uploaduser: allow emailstop to be set during upload.

carlooos28 · Sep 15, 2019 · c4e79fc · c4e79fc
1 parent 1c3efe4
commit c4e79fc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/admin/tool/uploaduser/index.php b/admin/tool/uploaduser/index.php
@@ -86,7 +86,7 @@
 $today = make_timestamp(date('Y', $today), date('m', $today), date('d', $today), 0, 0, 0);
 
 // array of all valid fields for validation
-$STD_FIELDS = array('id', 'username', 'email',
+$STD_FIELDS = array('id', 'username', 'email', 'emailstop',
         'city', 'country', 'lang', 'timezone', 'mailformat',
         'maildisplay', 'maildigest', 'htmleditor', 'autosubscribe',
         'institution', 'department', 'idnumber', 'skype',

diff --git a/admin/tool/uploaduser/user_form.php b/admin/tool/uploaduser/user_form.php
@@ -231,6 +231,11 @@ function definition () {
         $mform->setDefault('maildisplay', core_user::get_property_default('maildisplay'));
         $mform->addHelpButton('maildisplay', 'emaildisplay');
 
+        $choices = array(0 => get_string('emailenable'), 1 => get_string('emaildisable'));
+        $mform->addElement('select', 'emailstop', get_string('emailstop'), $choices);
+        $mform->setDefault('emailstop', core_user::get_property_default('emailstop'));
+        $mform->setAdvanced('emailstop');
+
         $choices = array(0 => get_string('textformat'), 1 => get_string('htmlformat'));
         $mform->addElement('select', 'mailformat', get_string('emailformat'), $choices);
         $mform->setDefault('mailformat', core_user::get_property_default('mailformat'));

diff --git a/lang/en/moodle.php b/lang/en/moodle.php
@@ -723,6 +723,7 @@
 $string['emailresetconfirmsent'] = 'An email has been sent to your address at <b>{$a}</b>.
 <br />It contains easy instructions to confirm and complete this password change.
 If you continue to have difficulty, contact the site administrator.';
+$string['emailstop'] = 'Email stop';
 $string['emailtoprivatefiles'] = 'You can also e-mail files as attachments straight to your private files space. Simply attach your files to an e-mail and send it to {$a}';
 $string['emailtoprivatefilesdenied'] = 'Your administrator has disabled the option to upload your own private files.';
 $string['emailvia'] = '{$a->name} (via {$a->siteshortname})';

diff --git a/lib/classes/user.php b/lib/classes/user.php
@@ -680,7 +680,7 @@ protected static function fill_properties_cache() {
         $fields['lastname'] = array('type' => PARAM_NOTAGS, 'null' => NULL_NOT_ALLOWED);
         $fields['surname'] = array('type' => PARAM_NOTAGS, 'null' => NULL_NOT_ALLOWED);
         $fields['email'] = array('type' => PARAM_RAW_TRIMMED, 'null' => NULL_NOT_ALLOWED);
-        $fields['emailstop'] = array('type' => PARAM_INT, 'null' => NULL_NOT_ALLOWED);
+        $fields['emailstop'] = array('type' => PARAM_INT, 'null' => NULL_NOT_ALLOWED, 'default' => 0);
         $fields['icq'] = array('type' => PARAM_NOTAGS, 'null' => NULL_NOT_ALLOWED);
         $fields['skype'] = array('type' => PARAM_NOTAGS, 'null' => NULL_ALLOWED);
         $fields['aim'] = array('type' => PARAM_NOTAGS, 'null' => NULL_NOT_ALLOWED);