Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams Webhook to include team name #361

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

caronc
Copy link
Owner

@caronc caronc commented Feb 16, 2021

Description:

Related issue (if applicable): apprise-api/38

Microsoft Teams now requires webhook to include the Team Name in it (instead of outlook). This may require people to re-generate their Incoming Webhooks. The MSTeams URL construction changes slightly from:

  • msteams://token_a/token_b/token_c/
    to:
  • msteams://team-name/token_a/token_b/token_c/

This change is backwards compatible as if no team-name is specified then it uses outlook and produces a deprecation warning to the user.

The team name can be found in the generated webhook which looks like:

# https://TEAM-NAME.office.com/webhook/ABCD/IncomingWebhook/DEFG/HIJK
#             ^                         ^                    ^    ^
#             |                         |                    |    |
#  These are important <----------------^--------------------^----^

vs the legacy URL which looked like (always stating outlook):

# https://outlook.office.com/webhook/ABCD/IncomingWebhook/DEFG/HIJK
#           ^                         ^                    ^    ^
#           |                         |                    |    |
#   legacy team reference: 'outlook'  |                    |    |
#                                     |                    |    |
#  These are important <--------------^--------------------^----^

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@caronc caronc force-pushed the msteams-team-required-update branch from 7c08176 to 47bf1a9 Compare February 22, 2021 19:27
@caronc caronc merged commit 9e9b140 into master Feb 22, 2021
@caronc caronc deleted the msteams-team-required-update branch February 28, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant