Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement carried-forward string handling option 4 #70

Open
wants to merge 25 commits into
base: upd-v3
Choose a base branch
from

Conversation

delosh653
Copy link
Collaborator

@delosh653 delosh653 commented Sep 30, 2021

Implements option 4 for carried-forward string handling:

Evaluate all carried-forwards based on position in string from i=1:n (n = the maximum length of a CF-string). Evaluate each CF based on the include before and after (if available). At the end of each evaluation for each subject's CF at position i, do not further evaluate strings where the CF at the current position has been marked for exclusion. Whittle down the search space in this manner until either there are no more subjects to evaluate or we have evaluated all subjects.

There also may be some future optimization for this option if we choose to go with it.

Also:

  • fixes a small bug in option 3
  • Implements option 5: uses the sweeping strategy of option 4, but with the answers from acf-answers evaluated for each carried-forward.

@delosh653 delosh653 requested a review from dchud September 30, 2021 19:40
@delosh653
Copy link
Collaborator Author

I'd like to also explicitly add this in to the docs for testacf() -- may be waiting for the checks on #69 to fix.

@delosh653 delosh653 changed the base branch from main to upd-v3 December 8, 2022 13:48
@dchud dchud added this to the v3.0.0 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants