Sprite image layout class #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace SpriteImageDirective.SpriteImageLayout enum with SpriteImageLayout interface - try to stop checking for an enum value and check Class.isAssignableFrom - add new SpriteImageDirective.valueOf method to output a SpriteImageLayout by convention - add implementations of SpriteImageLayout (HorizontalLayout and VerticalLayout) and put as many things as possible in there. - modify test cases to use new valueOf method
- move to SpriteImageLayout.calculateRepeatAlignmentDimension - add AbstractLayout.getDimensions
- put return value in local variable and set initial value to defaultLayout
correctAlignment + getDefaultAlignment methods use SpriteImageLayout methods instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to refactor layouts out of an enum into a proper class. Use a naming convention on layout id to map to a specific implementation. This should open the possibility of swapping in different layout algorithms such as https://github.com/clyfish/zerosprites or http://issues.carrot2.org/browse/SMARTSPRITES-64.
Ticket http://issues.carrot2.org/browse/SMARTSPRITES-92