update fork #25
Closed
update fork #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[macOS] Adjust padding of List items on sidebar
Change the comment author color to the accentColor if the comment author is the same as the post author.
When post author = comment author, set comment author color
Create previews for the Shared views
Quite a lot of changes in order to achieve this: - had to activate the navigation link programmatically in order to capture single and double tap - NavigationLink activated based on new view state for selected post tag - moved the RequestView to the ContentView so the selected post wouldn't reload the whole PostList and retriever the request - PostList now initialised with Listing object - setting the contentShape of the PostView in the list in order to capture hits in the whole area, otherwise it would land on the NavigationLink behind - adding two tap gestures in order of precedence - set the default frame for the new spinner to guarantee a minimum size while loading The only secondary effect from this solution I wasn't able to fix is that now cells don't get a selected state like before. I accept suggestions.
Moves the thumbnails to the right side of the PostView for legibility
Added a spacer to PostView to align thumbnails to the right
…st id init parameters; Using a computed property for the list and navigation link selections; Listing now has a computed property to return an array of Posts.
Made the section non-collapsible
Allows for single and double tap on each post
Now PostList has 3 states: loading, no results, and listing results.
Fixes an issue that would resize the whole window when reloading
|
Could you please provide more details as to what changes you made. And please also try to rebase. There's a lot of commits here that have already been merged, it'd make it much easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.