Skip to content

Commit

Permalink
Fix T99876: FBX exporting animation with 1 fps
Browse files Browse the repository at this point in the history
As suggested by Omar Emara (@OmarSquircleArt), break after first
matching framerate found, instead of searching the whole list everytime,
ending up selecting the last matching value.

NTSC 'drop frame' type are rather unusual, they should never be
auto-selected anyway.
  • Loading branch information
Bastien Montagne committed Oct 7, 2022
1 parent eb09be7 commit f3975a3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion io_scene_fbx/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
bl_info = {
"name": "FBX format",
"author": "Campbell Barton, Bastien Montagne, Jens Restemeier",
"version": (4, 37, 0),
"version": (4, 37, 1),
"blender": (3, 4, 0),
"location": "File > Import-Export",
"description": "FBX IO meshes, UV's, vertex colors, materials, textures, cameras, lamps and actions",
Expand Down
1 change: 1 addition & 0 deletions io_scene_fbx/export_fbx_bin.py
Original file line number Diff line number Diff line change
Expand Up @@ -2842,6 +2842,7 @@ def fbx_header_elements(root, scene_data, time=None):
if similar_values(fps, ref_fps):
fbx_fps = ref_fps
fbx_fps_mode = fps_mode
break
elem_props_set(props, "p_enum", b"TimeMode", fbx_fps_mode)
elem_props_set(props, "p_timestamp", b"TimeSpanStart", 0)
elem_props_set(props, "p_timestamp", b"TimeSpanStop", FBX_KTIME)
Expand Down

0 comments on commit f3975a3

Please sign in to comment.