Close S3 objects to release connection resources

cashapp · May 2, 2023 · d67d14a · d67d14a
1 parent 83eb314
commit d67d14a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/client-s3/src/main/kotlin/app/cash/backfila/client/s3/internal/RealS3Service.kt b/client-s3/src/main/kotlin/app/cash/backfila/client/s3/internal/RealS3Service.kt
@@ -30,14 +30,18 @@ class RealS3Service @Inject constructor(
 
   override fun getFileStreamStartingAt(bucket: String, key: String, start: Long): BufferedSource {
     val s3Object = amazonS3.getObject(GetObjectRequest(bucket, key).withRange(start))
-    return s3Object.objectContent.source().buffer()
+    return s3Object.use {
+      it.objectContent.source().buffer()
+    }
   }
 
   override fun getWithSeek(bucket: String, key: String, seekStart: Long, seekEnd: Long): ByteString {
     val s3Object = amazonS3.getObject(GetObjectRequest(bucket, key).withRange(seekStart, seekEnd))
     return Buffer().run {
-      writeAll(s3Object.objectContent.source())
-      readByteString()
+      s3Object.use {
+        writeAll(it.objectContent.source())
+        readByteString()
+      }
     }
   }
 }