Merge pull request cli#4756 from cli/no-idle-default

Remove the default value from idle-timeout
castrojo · Nov 19, 2021 · 3aef78f · 3aef78f
2 parents 6f13c1e + 91dc722
commit 3aef78f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/codespaces/api/api.go b/internal/codespaces/api/api.go
@@ -507,7 +507,7 @@ func (a *API) CreateCodespace(ctx context.Context, params *CreateCodespaceParams
 
 type startCreateRequest struct {
 	RepositoryID       int    `json:"repository_id"`
-	IdleTimeoutMinutes int    `json:"idle_timeout_minutes"`
+	IdleTimeoutMinutes int    `json:"idle_timeout_minutes,omitempty"`
 	Ref                string `json:"ref"`
 	Location           string `json:"location"`
 	Machine            string `json:"machine"`

diff --git a/pkg/cmd/codespace/create.go b/pkg/cmd/codespace/create.go
@@ -36,7 +36,7 @@ func newCreateCmd(app *App) *cobra.Command {
 	createCmd.Flags().StringVarP(&opts.branch, "branch", "b", "", "repository branch")
 	createCmd.Flags().StringVarP(&opts.machine, "machine", "m", "", "hardware specifications for the VM")
 	createCmd.Flags().BoolVarP(&opts.showStatus, "status", "s", false, "show status of post-create command and dotfiles")
-	createCmd.Flags().DurationVar(&opts.idleTimeout, "idle-timeout", 30*time.Minute, "allowed inactivity before codespace is stopped, e.g. \"10m\", \"1h\"")
+	createCmd.Flags().DurationVar(&opts.idleTimeout, "idle-timeout", 0, "allowed inactivity before codespace is stopped, e.g. \"10m\", \"1h\"")
 
 	return createCmd
 }