Merge pull request #588 from catho/QTM-786

feat(QTM-786): Added "button" type to prevent form submission when opening options list
catho · Oct 2, 2024 · 160f344 · 160f344
2 parents c0af9c5 + a62fd85
commit 160f344
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/components/DropdownLight/DropdownLight.jsx b/components/DropdownLight/DropdownLight.jsx
@@ -330,6 +330,7 @@ const DropdownLight = ({
           required={required}
         />
         <Button
+          type="button"
           aria-haspopup="true"
           aria-label={isOpen ? 'fechar lista de itens' : 'abrir lista de itens'}
           onClick={handleToggleDropdown}

diff --git a/components/DropdownLight/__snapshots__/DropdownLight.unit.test.jsx.snap b/components/DropdownLight/__snapshots__/DropdownLight.unit.test.jsx.snap
@@ -147,6 +147,7 @@ exports[`<DropdownLight /> should match the snapshots 1`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -315,6 +316,7 @@ exports[`<DropdownLight /> should match the snapshots 2`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -506,6 +508,7 @@ exports[`<DropdownLight /> should match the snapshots 3`] = `
         aria-label="abrir lista de itens"
         class="c6"
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -685,6 +688,7 @@ exports[`<DropdownLight /> should match the snapshots 4`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -873,6 +877,7 @@ exports[`<DropdownLight /> should match the snapshots 5`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -1046,6 +1051,7 @@ exports[`<DropdownLight /> should match the snapshots 6`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         this is a input placeholder
         <svg
@@ -1215,6 +1221,7 @@ exports[`<DropdownLight /> should match the snapshots 7`] = `
         class="c4"
         disabled=""
         id=""
+        type="button"
       >
         Select an option
         <svg
@@ -1383,6 +1390,7 @@ exports[`<DropdownLight /> should match the snapshots 8`] = `
         aria-label="abrir lista de itens"
         class="c4"
         id=""
+        type="button"
       >
         Select an option
         <svg