Skip to content

Commit

Permalink
hwrng: omap - remove incorrect __exit markups
Browse files Browse the repository at this point in the history
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
dtor authored and herbertx committed Mar 11, 2015
1 parent 007ee8d commit 1ee9b5e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/hw_random/omap-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ static int omap_rng_probe(struct platform_device *pdev)
return ret;
}

static int __exit omap_rng_remove(struct platform_device *pdev)
static int omap_rng_remove(struct platform_device *pdev)
{
struct omap_rng_dev *priv = platform_get_drvdata(pdev);

Expand Down Expand Up @@ -460,7 +460,7 @@ static struct platform_driver omap_rng_driver = {
.of_match_table = of_match_ptr(omap_rng_of_match),
},
.probe = omap_rng_probe,
.remove = __exit_p(omap_rng_remove),
.remove = omap_rng_remove,
};

module_platform_driver(omap_rng_driver);
Expand Down

0 comments on commit 1ee9b5e

Please sign in to comment.