Skip to content

Commit

Permalink
Input: stmpe-keypad - fix valid key line bitmask
Browse files Browse the repository at this point in the history
The bitmask comment says it will enable GPIO 8-14 and 16-20 for keypad use,
but it actually enables GPIO 8-11 and 13-20 due to a bit error.

Instead of masking of the "hole" at GPIO 12 (which is used for keypad
output 4) mask of the proper "hole" at GPIO 15.

Signed-off-by: Linus Walleij <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
  • Loading branch information
linusw authored and dtor committed Oct 24, 2014
1 parent 4668546 commit 2175b0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/input/keyboard/stmpe-keypad.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static const struct stmpe_keypad_variant stmpe_keypad_variants[] = {
.max_cols = 8,
.max_rows = 12,
.col_gpios = 0x0000ff, /* GPIO 0 - 7*/
.row_gpios = 0x1fef00, /* GPIO 8-14, 16-20 */
.row_gpios = 0x1f7f00, /* GPIO 8-14, 16-20 */
},
[STMPE2403] = {
.auto_increment = true,
Expand Down

0 comments on commit 2175b0f

Please sign in to comment.