Skip to content

Commit

Permalink
lguest: fix comment style
Browse files Browse the repository at this point in the history
I don't really notice it (except to begrudge the extra vertical
space), but Ingo does.  And he pointed out that one excuse of lguest
is as a teaching tool, it should set a good example.

Signed-off-by: Rusty Russell <[email protected]>
Cc: Ingo Molnar <[email protected]>
  • Loading branch information
rustyrussell committed Jul 30, 2009
1 parent e969fed commit 2e04ef7
Show file tree
Hide file tree
Showing 17 changed files with 1,906 additions and 1,015 deletions.
540 changes: 349 additions & 191 deletions Documentation/lguest/lguest.c

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions arch/x86/include/asm/lguest.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
/* Pages for switcher itself, then two pages per cpu */
#define TOTAL_SWITCHER_PAGES (SHARED_SWITCHER_PAGES + 2 * nr_cpu_ids)

/* We map at -4M (-2M when PAE is activated) for ease of mapping
* into the guest (one PTE page). */
/* We map at -4M (-2M for PAE) for ease of mapping (one PTE page). */
#ifdef CONFIG_X86_PAE
#define SWITCHER_ADDR 0xFFE00000
#else
Expand Down
10 changes: 5 additions & 5 deletions arch/x86/include/asm/lguest_hcall.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
#include <asm/hw_irq.h>
#include <asm/kvm_para.h>

/*G:030 But first, how does our Guest contact the Host to ask for privileged
/*G:030
* But first, how does our Guest contact the Host to ask for privileged
* operations? There are two ways: the direct way is to make a "hypercall",
* to make requests of the Host Itself.
*
Expand All @@ -41,16 +42,15 @@
*
* Grossly invalid calls result in Sudden Death at the hands of the vengeful
* Host, rather than returning failure. This reflects Winston Churchill's
* definition of a gentleman: "someone who is only rude intentionally". */
/*:*/
* definition of a gentleman: "someone who is only rude intentionally".
:*/

/* Can't use our min() macro here: needs to be a constant */
#define LGUEST_IRQS (NR_IRQS < 32 ? NR_IRQS: 32)

#define LHCALL_RING_SIZE 64
struct hcall_args {
/* These map directly onto eax, ebx, ecx, edx and esi
* in struct lguest_regs */
/* These map directly onto eax/ebx/ecx/edx/esi in struct lguest_regs */
unsigned long arg0, arg1, arg2, arg3, arg4;
};

Expand Down
Loading

0 comments on commit 2e04ef7

Please sign in to comment.