[media] uvcvideo: Return -EACCES when trying to access a read/write-o…

…nly control The proper return code according to the V4L2 specification is -EACCES, not -EINVAL. Signed-off-by: Laurent Pinchart <[email protected]> Acked-by: Hans Verkuil <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
cbmeeks · Nov 28, 2012 · 30ecb93 · 30ecb93
1 parent f0ed2ce
commit 30ecb93
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -927,7 +927,7 @@ static int __uvc_ctrl_get(struct uvc_video_chain *chain,
 	int ret;
 
 	if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) == 0)
-		return -EINVAL;
+		return -EACCES;
 
 	if (!ctrl->loaded) {
 		ret = uvc_query_ctrl(chain->dev, UVC_GET_CUR, ctrl->entity->id,
@@ -1435,7 +1435,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
 	if (ctrl == NULL)
 		return -ENOENT;
 	if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR))
-		return -EINVAL;
+		return -EACCES;
 
 	/* Clamp out of range values. */
 	switch (mapping->v4l2_type) {